Fix in fan error handling

LICENSE

@@ -1,3 +1,5 @@
+MIT No Attribution
+
 Copyright 2025 admin@long-cat.net
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so.

README.md

@@ -3,7 +3,7 @@
 This program allows you to read temperature sensors off of supported EVGA 30-series iCX3 video cards, as well as control the fans individually.
 
 ## Prerequisites
-A supported EVGA 30-series iCX3 card.  I have not done extensive testing but belive this is every model of their:
+A supported EVGA 30-series card with iCX3.  This includes:
 * RTX 3060 Ti
 * RTX 3070
 * RTX 3070 Ti
@@ -14,6 +14,8 @@ A supported EVGA 30-series iCX3 card.  I have not done extensive testing but bel
 
 The number of fans supported depends, of course, on your particular model.
 
+You must have the `i2c-dev` kernel module loaded with `modprobe i2c-dev`
+
 Access to the `/dev/i2c` device files, which means either:
 * Run as root, or
 * Install udev rules to allow user access. If you have the OpenRGB udev rules installed to control the LEDs you already have this set up.
@@ -29,7 +31,7 @@ Access to the `/dev/i2c` device files, which means either:
 ## Optional features
 
 ### NVML support
-Add the make flag `USE_NVML=1` and the it will also display the main GPU temperature ("GPU1") as reported by the NVIDIA driver.  It will also display the performance cap/clock reason.  This requires the NVIDIA management library (NVML) to be installed.
+Add the make flag `USE_NVML=1` and the it will also display the main GPU temperature ("GPU1") as reported by the NVIDIA driver.  It will also display the performance cap/clock reason and memory controller utilization.  This requires the NVIDIA management library (NVML) to be installed.
 
 ### VRAM and Hotspot temperature
 Add the make flag `USE_LIBPCI=1` and you can also read the VRAM and "hotspot" temperatures.  These require direct memory access to the PCI device so you must run as root and also enable the kernel parameter `iomem=relaxed`.  These sensors are **extremely** undocumented so I can't say anything about their accuracy.
@@ -39,6 +41,7 @@ Note that when controlling fans directly through iCX3 they will fall offline fro
 
 ```text
 Available options:
+--i2c N      : Only probe I2C bus N instead of all (may help with stuttering or freezing when probing I2C devices)
 --gpu N      : Control only GPU N instead of all supported cards
 --fan SPEED  : Set all fans at once to SPEED (see below)
 --fanN SPEED : Set fan N (0-3) to SPEED
@@ -59,29 +62,30 @@ Read sensors:
 ```text
 $ ./evga-icx
 #0: EVGA GeForce RTX 3090 FTW3 Ultra v2 (/dev/i2c-3) @ c:00.0
-Fan 0: 2133 RPM (71/0%, Auto)
+Fan 0: 1751 RPM (58/0%, Auto)
-Fan 1: 2123 RPM (70/0%, Auto)
+Fan 1: 1730 RPM (57/0%, Auto)
-Fan 2: 2122 RPM (70/0%, Offset)
+Fan 2: 1712 RPM (57/0%, Offset)
 Ext. fan: 0 RPM (0/0%, Offset)
-GPU1: +73°C
+GPU1: +65°C
-GPU2: +70.6°C
+GPU2: +57.8°C
-VRAM: +86°C
+VRAM: +74°C
-MEM1: +68.9°C
+MEM1: +56.1°C
-MEM2: +65.1°C
+MEM2: +53.5°C
-MEM3: +70.2°C
+MEM3: +55.5°C
-PWR1: +60.9°C
+PWR1: +48.2°C
-PWR2: +66.4°C
+PWR2: +53.2°C
-PWR3: +73.0°C
+PWR3: +59.6°C
-PWR4: +71.5°C
+PWR4: +58.0°C
-PWR5: +65.6°C
+PWR5: +51.1°C
-HotSpot: +84°C
+HotSpot: +75°C
+Mem util: 43%
 Clock reasons: Power cap (0x4)
 ```
 
 Compact one-line mode:
 ```text
 $ ./evga-icx --compact
-#0 FAN  72  72  72   0% GPU  76  73 MEM  90  72  67  72 PWR  63  69  76  74  68 HOT  86°C  CLK Pwr
+#0 FAN  59  59  58   0% GPU  66  60 MEM  74  58  55  58 PWR  49  55  61  60  53 HOT  77°C  MEM  42% CLK Pwr
 ```
 
 Set external fan to follow Nvidia driver controlled speed with a -500 RPM offset:

evga-card.c

@@ -8,7 +8,7 @@
 
 /* Search all i2c device files for ones are on a PCI device of a supported GPU,
    and respond with the correct iCX3 version information */
-int find_evga_gpu_i2cs(struct card_info *infos, int max_gpus)
+int find_evga_gpu_i2cs(struct card_info *infos, int max_gpus, int i2c_bus)
 {
 	char i2c_devices_path[NAME_MAX];
 	char device_path[NAME_MAX];
@@ -20,6 +20,7 @@ int find_evga_gpu_i2cs(struct card_info *infos, int max_gpus)
 	struct dirent *ent;
 	
 	int num_gpus = 0;
+	int current_i2c_bus = -1;
 	unsigned short pci_vendor, pci_device, pci_subsystem_vendor, pci_subsystem_device = 0;
 	
 	/* Start looking for I2C adapters in /sys/bus/i2c/devices/ */
@@ -37,6 +38,14 @@ int find_evga_gpu_i2cs(struct card_info *infos, int max_gpus)
 		if(strncmp(ent->d_name, "i2c-", 4) != 0) 
 			continue;
 		
+		/* Only probe the specific device given (if provided) */
+		if (i2c_bus >= 0) {
+			sscanf(ent->d_name, "i2c-%i", &current_i2c_bus);
+			if (current_i2c_bus != i2c_bus)
+				continue;
+		}
+		
+		
 		strcpy(device_path, i2c_devices_path);
 		strcat(device_path, ent->d_name);
 		

evga-card.h

@@ -91,6 +91,9 @@ struct card_info {
 	int i2c_fd;							/* File descriptor for the i2c device file, for re-use */
 	int product_id;						/* EVGA internal product ID, as reported by the iCX3 controller */
 	unsigned int bar0;					/* Address of the card's PCI base address register */
+	void *nvml_device;					/* Pointer to nvmlDevice_t for use in NVML calls */
+	void *vram_addr;					/* Memory mapping for GDDR6 temps */
+	void *hotspot_addr;					/* Memory mapping for hotspot temperature */
 };
 
 struct gpu_pci_info {
@@ -162,7 +165,7 @@ static struct gpu_pci_info evga_pci_ids[] =
 	{"EVGA GeForce RTX 3090 Ti FTW3 Ultra Gaming"          , NVIDIA_VEN,   NVIDIA_RTX3090TI_DEV,       EVGA_SUB_VEN,   EVGA_RTX3090TI_FTW3_ULTRA_GAMING_SUB_DEV      }
 };
 
-int find_evga_gpu_i2cs(struct card_info *infos, int max_gpus);
+int find_evga_gpu_i2cs(struct card_info *infos, int max_gpus, int i2c_bus);
 unsigned short read_pci_id(char *device_path, char *field);
 char *read_nvidia_pci_address(char *device_path);
 

evga-icx.c

@@ -24,7 +24,8 @@ char *header_start = "";
 char *header_end = "";
 
 static const char helpstring[] = "Available options:\n"
-                                 "--gpu N      : Control only GPU N instead of all supported cards\n"
+								 "--i2c N      : Only probe I2C bus N instead of all (may help with stuttering or freezing when probing I2C devices)\n"
+								 "--gpu N      : Control only GPU N instead of all supported cards\n"
 								 "--fan SPEED  : Set all fans at once to SPEED (see below)\n"
 								 "--fanN SPEED : Set fan N (0-3) to SPEED\n"
 								 "    SPEED may be one of the following:\n"
@@ -47,13 +48,22 @@ int main (int argc, char **argv)
 	int print_info = 0;
 	int compact = 0;
 	int gpu_num = -1;    /* Card to control */
+	int i2c_bus = -1;
 	int overwrite = 0;
 	unsigned int watch = 0;
 	char *fan_speed[ICX3_MAX_FANS] = {NULL}; 
 	
 	/* Input parsing */
 	for (int i = 1; i < argc; i++){
-		if (strcmp(argv[i], "--gpu") == 0) {
+		if (strcmp(argv[i], "--i2c") == 0) {
+			i++;
+			if (i < argc) {
+				i2c_bus = atoi(argv[i]);
+			} else {
+				printf(helpstring);
+				return -1;
+			}
+		} else if (strcmp(argv[i], "--gpu") == 0) {
 			i++;
 			if (i < argc) {
 				gpu_num = atoi(argv[i]);
@@ -119,7 +129,7 @@ int main (int argc, char **argv)
 	if (overwrite && !compact)
 		overwrite = 0;
 	
-	gpu_count = find_evga_gpu_i2cs(gpus, MAX_GPUS);
+	gpu_count = find_evga_gpu_i2cs(gpus, MAX_GPUS, i2c_bus);
 
 	if (gpu_count == -1) {
 		printf("Error scanning I2C devices\n");
@@ -153,6 +163,8 @@ int main (int argc, char **argv)
 	/* NVML init */
 #ifdef USE_NVML
     init_nvml();
+	for (int i = 0; i < gpu_count; i++)
+		get_nvml_handle(&gpus[i]);
 #endif
 
 	/* PCI init for VRAM/hotspot temps */
@@ -164,7 +176,8 @@ int main (int argc, char **argv)
 	/* print sensor info */
 	if (print_info) {
 		do {
-			printf("\x1b[K");	/* Clear current console line (really just for overwrite mode) */
+			if (overwrite)
+				printf("\x1b[K");	/* Clear current console line */
 			
 			if (gpu_num == -1) {
 				/* No GPU specified on command line, loop over all supported GPUs */
@@ -226,6 +239,8 @@ void print_gpu_info(int gpu_num, struct card_info *gpu, int compact) {
 		printf("°C ");
 		
 #ifdef USE_NVML
+		printf("%s MEM %s", header_start, header_end);
+		printf("%3d%%", get_nvml_mem_util(gpu));
 		printf("%s CLK %s", header_start, header_end);
 		print_nvml_clock_reason(1, gpu);
 #endif
@@ -256,8 +271,10 @@ void print_gpu_info(int gpu_num, struct card_info *gpu, int compact) {
 #endif
 
 #ifdef USE_NVML
+		printf("Mem util: %d%%\n", get_nvml_mem_util(gpu));
 		printf("Clock reasons: ");
 		print_nvml_clock_reason(0, gpu);
+		printf("\n");
 #endif
 	}
 	

gddr6.c

@@ -36,70 +36,69 @@ void init_gddr6(struct card_info *card)
 	card->bar0 = (pci_dev->base_addr[0] & 0xFFFFFFFF);
 
 	pci_cleanup(pacc);
-}
-
-float get_vram_temp(struct card_info *card)
-{
-	int fd;
-	float temp = 0.0;
 	
+	/* Open our memory mappings */
+	card->vram_addr = NULL;
+	card->hotspot_addr = NULL;
+	
+	int fd;
 	if ((fd = open("/dev/mem", O_RDWR | O_SYNC)) == -1)
     {
-        printf("Can't read memory. If you are root, enable kernel parameter iomem=relaxed\n");
+        printf("Can't read memory for VRAM and Hotspot temperatures. If you are root, enable kernel parameter iomem=relaxed\n");
-		return 0;
+		return;
     }
 	
+	unsigned int phys_addr, base_offset;
+	void *map_base;
+	
 	for (int i = 0; i < sizeof(device_offset_info) / sizeof(struct device_offset); i++) {
 		if (card->pci_device_id == device_offset_info[i].device_id){
-			unsigned int phys_addr = (card->bar0 + device_offset_info[i].vram_offset);
+			/* Map for VRAM */
-			unsigned int base_offset = phys_addr & ~(PG_SZ-1);
+			phys_addr = (card->bar0 + device_offset_info[i].vram_offset);
-			void *map_base = mmap(0, PG_SZ, PROT_READ, MAP_SHARED, fd, base_offset);
+			base_offset = phys_addr & ~(PG_SZ-1);
+			map_base = mmap(0, PG_SZ, PROT_READ, MAP_SHARED, fd, base_offset);
 			if(map_base == (void *) -1)
-			{
+				printf("Can't map memory for VRAM temperature. If you are root, enable kernel parameter iomem=relaxed\n");
-				if (fd != -1)
+			else
-					close(fd);
+				card->vram_addr = (void *) map_base + (phys_addr - base_offset);
-				printf("Can't read memory for VRAM temperature. If you are root, enable kernel parameter iomem=relaxed\n");
+			
-			}
+			
-			void *virt_addr = (char *) map_base + (phys_addr - base_offset);
+			/* Map for hotspot */
-			int read_result = *((unsigned int *) virt_addr);
+			phys_addr = (card->bar0 + device_offset_info[i].hotspot_offset);
-			temp = ((read_result & 0x00000fff) / 0x20);
+			base_offset = phys_addr & ~(PG_SZ-1);
-			munmap(map_base, PG_SZ);
+			map_base = mmap(0, PG_SZ, PROT_READ, MAP_SHARED, fd, base_offset);
+			if(map_base == (void *) -1)
+				printf("Can't map memory for Hotspot temperature. If you are root, enable kernel parameter iomem=relaxed\n");
+			else
+				card->hotspot_addr = (void *) map_base + (phys_addr - base_offset);
 		}
 	}
 	
 	close(fd);
+}
+
+float get_vram_temp(struct card_info *card)
+{
+	float temp = 0.0;
+	
+	if(card->vram_addr == NULL)
+		return 0.0;
+
+	int read_result = *((unsigned int *) card->vram_addr);
+	temp = ((read_result & 0x00000fff) / 0x20);
+
 	return temp;
 }
 
 float get_hotspot_temp(struct card_info *card)
 {
-	int fd;
 	float temp = 0.0;
 	
-	if ((fd = open("/dev/mem", O_RDWR | O_SYNC)) == -1)
+	if(card->hotspot_addr == NULL)
-    {
+		return 0.0;
-        printf("Can't read memory. If you are root, enable kernel parameter iomem=relaxed\n");
+
-		return 0;
+	int read_result = *((unsigned int *) card->hotspot_addr);
-    }
+	temp = (read_result >> 8) & 0xff;
-	
+
-	for (int i = 0; i < sizeof(device_offset_info) / sizeof(struct device_offset); i++) {
-		if (card->pci_device_id == device_offset_info[i].device_id){
-			unsigned int phys_addr = (card->bar0 + device_offset_info[i].hotspot_offset);
-			unsigned int base_offset = phys_addr & ~(PG_SZ-1);
-			void *map_base = mmap(0, PG_SZ, PROT_READ, MAP_SHARED, fd, base_offset);
-			if(map_base == (void *) -1)
-			{
-				if (fd != -1)
-					close(fd);
-				printf("Can't read memory for hotspot. If you are root, enable kernel parameter iomem=relaxed\n");
-			}
-			void *virt_addr = (char *) map_base + (phys_addr - base_offset);
-			int read_result = *((unsigned int *) virt_addr);
-			temp = (read_result >> 8) & 0xff;
-			munmap(map_base, PG_SZ);
-		}
-	}
-	
-	close(fd);
 	return temp;
 }

icx3.c

@@ -237,6 +237,6 @@ void set_fan(int fan, char *setting, struct card_info *card)
 	if (fan_readback.fanmode    != fan_control.fanmode ||
 		fan_readback.rpm_offset != fan_control.rpm_offset ||
 		fan_readback.duty       != fan_control.duty)
-		printf("Error setting fan %d on %s\n", fan, card->i2c_fd);
+		printf("Error setting fan %d on %s\n", fan, card->i2c_dev_path);
 }
 

nvidia-sensors.c

@@ -10,6 +10,16 @@ void init_nvml()
 		printf("Could not init NVML: %s\n", nvmlErrorString(result));
 }
 
+void get_nvml_handle(struct card_info *card)
+{
+	nvmlReturn_t result;
+	result = nvmlDeviceGetHandleByPciBusId_v2(card->pci_id, card->nvml_device);
+	if (result != NVML_SUCCESS) {
+		printf("Failed to get NVML device handle for card at %s: %s\n", card->pci_id, nvmlErrorString(result));
+		card->nvml_device = NULL;
+	}
+}
+
 void print_nvml_clock_reason(int compact, struct card_info *card)
 {
 	unsigned long long reasons = get_nvml_clock_reasons(card);
@@ -36,21 +46,16 @@ void print_nvml_clock_reason(int compact, struct card_info *card)
 		printf("None");
 	
 	if (!compact)
-		printf(" (0x%llx)\n", reasons);
+		printf(" (0x%llx)", reasons);
 }
 
 unsigned int get_nvml_temp(struct card_info *card)
 {
-	nvmlReturn_t result;
+	if (card->nvml_device == NULL)
-	nvmlDevice_t nvml_device;
-	result = nvmlDeviceGetHandleByPciBusId_v2(card->pci_id, &nvml_device);
-	if (result != NVML_SUCCESS) {
-		printf("Failed to get device handle for card at %s: %s\n", card->pci_id, nvmlErrorString(result));
 		return 0;
-	}
 	
 	unsigned int temp;
-	result = nvmlDeviceGetTemperature(nvml_device, NVML_TEMPERATURE_GPU, &temp); 
+	nvmlReturn_t result = nvmlDeviceGetTemperature(*(nvmlDevice_t*)(card->nvml_device), NVML_TEMPERATURE_GPU, &temp); 
 	if (result != NVML_SUCCESS) {
 		printf("Failed to get temperature for card at %s: %s\n", card->pci_id, nvmlErrorString(result));
 		return 0;
@@ -60,16 +65,11 @@ unsigned int get_nvml_temp(struct card_info *card)
 
 unsigned long long get_nvml_clock_reasons(struct card_info *card)
 {
-	nvmlReturn_t result;
+	if (card->nvml_device == NULL)
-	nvmlDevice_t nvml_device;
-	result = nvmlDeviceGetHandleByPciBusId_v2(card->pci_id, &nvml_device);
-	if (result != NVML_SUCCESS) {
-		printf("Failed to get device handle for card at %s: %s\n", card->pci_id, nvmlErrorString(result));
 		return 0;
-	}
 	
 	unsigned long long reasons;
-	result = nvmlDeviceGetCurrentClocksEventReasons(nvml_device, &reasons) ; 
+	nvmlReturn_t result = nvmlDeviceGetCurrentClocksEventReasons(*(nvmlDevice_t*)(card->nvml_device), &reasons) ; 
 	if (result != NVML_SUCCESS) {
 		printf("Failed to get clock reasons for card at %s: %s\n", card->pci_id, nvmlErrorString(result));
 		return 0;
@@ -78,3 +78,18 @@ unsigned long long get_nvml_clock_reasons(struct card_info *card)
 	return reasons;
 }
 
+unsigned int get_nvml_mem_util(struct card_info *card)
+{
+	if (card->nvml_device == NULL)
+		return 0;
+	
+	nvmlUtilization_t util;
+	nvmlReturn_t result = nvmlDeviceGetUtilizationRates(*(nvmlDevice_t*)(card->nvml_device), &util);
+	if (result != NVML_SUCCESS) {
+		printf("Failed to get clock reasons for card at %s: %s\n", card->pci_id, nvmlErrorString(result));
+		return 0;
+	}
+	
+	return util.memory;
+}
+

nvidia-sensors.h

@@ -22,6 +22,8 @@ static struct clock_reason clock_reason_names[] =
 };
 
 void init_nvml();
+void get_nvml_handle(struct card_info *card);
 void print_nvml_clock_reason(int compact, struct card_info *card);
 unsigned int get_nvml_temp(struct card_info *card);
-unsigned long long get_nvml_clock_reasons(struct card_info *card);
+unsigned long long get_nvml_clock_reasons(struct card_info *card);
+unsigned int get_nvml_mem_util(struct card_info *card);